filament icon indicating copy to clipboard operation
filament copied to clipboard

Fix footer actions on content grid not aligning to the base of the container

Open rossbearman opened this issue 1 year ago • 7 comments

When a table is displayed as a grid using contentGrid(), if the heights of each row box differs, the footer actions will stick to the bottom of the content, rather than sitting flush with the bottom of the box.

A couple of people have encountered and reported this, and this fix has worked in those cases, but this PR has not been thoroughly tested, though it is a small change.

Visual Difference

Before: image

After: image

Functional changes

  • [ ] Conditionally switch to using flex h-full items-stretch on content grid rows in place of flex items-center

rossbearman avatar Jul 01 '24 10:07 rossbearman

I'm going to hold off on merging this PR, because I'm not sure if having the actions aligned at the bottom is desired for every use case.

zepfietje avatar Jul 19 '24 08:07 zepfietje

Would it make sense to have this available as an option on the content grid instead?

rossbearman avatar Jul 19 '24 08:07 rossbearman

Ideally there'd just be an actions component you could use to create the exact layout you want. Not sure if we're open to an API to configure the current actions position. What do you think, @danharrin?

zepfietje avatar Jul 19 '24 08:07 zepfietje

You'd need to be able to configure the parent container to align the actions to the bottom, so I don't think thats right

danharrin avatar Jul 21 '24 10:07 danharrin

From your comment it's unclear to me what direction we want to take, @danharrin. Care to clarify? 🙂

zepfietje avatar Jul 25 '24 09:07 zepfietje

Personally I can't think of a reason why this PR cannot be merged as-is

danharrin avatar Jul 25 '24 12:07 danharrin

Alright, let's reconsider this then.

zepfietje avatar Jul 25 '24 14:07 zepfietje

Going to close this as it has been fixed in v4 and there is a lack of activity here.

danharrin avatar Jan 31 '25 11:01 danharrin