filament icon indicating copy to clipboard operation
filament copied to clipboard

Loading + disabled state should apply disabled button styles

Open johnbacon opened this issue 8 months ago • 0 comments

Package

filament/filament

Package Version

Latest (v3)

Laravel Version

v10.x

Livewire Version

Latest (v3)

PHP Version

PHP 8.1.x

Problem description

Using form builder,[^1], when a form is submitted and submit button is in loading state, disabled=true is set but disabled styling is not applied.

[^1]: And possibly in other instances, this is only where we encountered it.

Expected behavior

The disabled button, when in the loading state, will have both the default cursor style and the opacity associated with a disabled button: https://github.com/filamentphp/filament/blob/ee26b8ffa90ac27506481b02ef886da570a32b37/packages/support/resources/views/components/button/index.blade.php#L55

Steps to reproduce

Using form builder, build a form, submit it with the button in loading state, and take a look!

Reproduction repository (issue will be closed if this is not valid)

https://github.com/filamentphp/demo

Relevant log output

No response

Donate 💰 to fund this issue

  • You can donate funding to this issue. We receive the money once the issue is completed & confirmed by you.
  • 100% of the funding will be distributed between the Filament core team to run all aspects of the project.
  • Thank you in advance for helping us make maintenance sustainable!
Fund with Polar

johnbacon avatar Jun 14 '24 17:06 johnbacon