glyphhanger icon indicating copy to clipboard operation
glyphhanger copied to clipboard

Include Option for Filename Suffix

Open bitstarr opened this issue 4 years ago • 2 comments

Currently all subsetted fonts will have a name like originalfilename-subset.woff. I would love to decide by my own if the -subset suffix is needed and which string it should be.

It seem like it's hard wired at the moment, see https://github.com/filamentgroup/glyphhanger/blob/master/src/GlyphHangerSubset.js#L87 Sadly I'm not that experienced in node.js to provide an accurate pull request.

bitstarr avatar Jan 24 '20 10:01 bitstarr

I worked around with this patch: https://github.com/filamentgroup/glyphhanger/compare/master...zk-phi:master

Note that suffix cannot start with -, since it's treated as an commandline option.

zk-phi avatar Feb 20 '21 15:02 zk-phi

I've just created a PR, but you may also use this patch https://github.com/zk-phi/zk-phi.github.io/commit/1f86c924a9ed6ecc12cccf810009f56570eec611 with patch-package npm package until it's merged.

zk-phi avatar Feb 20 '21 16:02 zk-phi