Jakub Filak

Results 40 comments of Jakub Filak

I am afraid that the None/null issue is a bug on pyodata. > In addition to the rules stated in the table, if the value of a primitive type is...

@bip91 Can you re-post the XML responses in JSON here? Just add `?$format=json` to the URL. Example: - XML = https://services.odata.org/V2/Northwind/Northwind.svc/Customers - JSON = https://services.odata.org/V2/Northwind/Northwind.svc/Customers?$format=json The example URLs point the...

Can you change the lines: ``` > except (TypeError, AttributeError): > modlog().warning(value) ``` to ``` > except (TypeError, AttributeError) as ex: > modlog().warning(f'Exception: {ex}') > modlog().warning(f'Property: {type_prop.name}') > modlog().warning(f'Value: {value}')...

@bip91 Do you think you can test my changes in PR: https://github.com/SAP/python-pyodata/pull/100 It only fixes the problem with None.

I cannot reproduce the problem. Didn't you touch this list: https://github.com/SAP/python-pyodata/blob/master/pyodata/v2/model.py#L2441

In my version of pyodata, the exception you got is raised at the line 2535 but in your case it's line 2451.

@bip91 It would help us if you create a new issue for the PATCH vs. MERGE request.

It should be easy to fix but I want to refactor the code to avoid duplication. Until we fix this, could you pass `str` instead of `list`, please? ```python .select(','.join(['Bukrs',...

Developer notes: ```diff def select(self, select): """Sets the selection clauses.""" - self._select = select + if isinstance(select, str): + self._select = select + elif isinstance(select, (list, tuple, set)): + self._select...

Event smarter solution would be: ```diff - def select(self, select): + def select(self, *select): """Sets the selection clauses.""" - self._select = select + if not select or select[0] is None:...