fikovnik
Latest release won't download
Would you be able to take a look at what I may have done wrong. In the other issue someone had mebtioned the problem beimg that i created a branch for the release files vs placing them directly on the master branch. Does that sound right? Other than that I followed the steps in the readme
Getting the same on 2 different MacBooks, one running 10.13 and the other running 10.12.
Both upgrading from 1.6.4.
Getting the same trying to go from 1.6.3 -> 1.6.5 Update errors out during download.
Hi everyone,
Please see if installing 1.6.6 works for you. I realized a few inconsistencies last time I released:
- the version number is listed in two places in the
ShiftIt-Info.plist; i only updated one last time. (README.md) has been updated. - I accidentally omitted the
version-prefix in the tag name
The reasons above make a lot more sense to me than having to commit directly to master as was suggested in a comment on another issue (can't find it now).
Please report back if installing 1.6.6 works; thanks!
Cool! Thanks! Still didn't get the Release Notes, but downloading and installing the new version worked fine.
Maybe updating from 1.6.3 -> 1.6.5 was a problem only if you manually downgraded from 1.6.4 to 1.6.3 (with the somewhat annoying resize feature) before. I remember updating to 1.6.5 didn't go automatically for me either. Then I realized my own action (the downgrade). What helped me is uninstall shiftit and install 1.6.5 fresh again. Updating from 1.6.5 to 1.6..6 automatically was no problem. No release notes visible for me either.
@fikovnik where do the release notes come from? i've been following the notes in the README with the additional manual steps after running fab release; maybe I'm running the manual steps incorrectly or inadvertently skipping a step.
@rca - first of all thanks a lot for putting the realeases together!
The release notes comes from the closed tickets that are part of a milestone. The python script gets the current mileston (e.g. 1.6.6) and then tries to find it on github. It takes all the closed issues and creates a sample HTML. I guess it might be a bit too overengineering so feel free to drop this.
Here is the HTML template: https://github.com/fikovnik/ShiftIt/blob/master/fabfile.py#L55 and here is the code that fetches them: https://github.com/fikovnik/ShiftIt/blob/master/fabfile.py#L142
More specifically, what is causing the spinner on the release notes dialog to go indefinitely? I suppose I'm missing a step that takes the release notes and places them somewhere; I think I've followed the manual instructions correctly, but I'm missing something.
On Mar 5, 2018, at 11:16 AM, Filip Krikava [email protected] wrote:
@rca https://github.com/rca - first of all thanks a lot for putting the realeases together!
The release notes comes from the closed tickets that are part of a milestone. The python script gets the current mileston (e.g. 1.6.6) and then tries to find it on github. It takes all the closed issues and creates a sample HTML. I guess it might be a bit too overengineering so feel free to drop this.
Here is the HTML template: https://github.com/fikovnik/ShiftIt/blob/master/fabfile.py#L55 https://github.com/fikovnik/ShiftIt/blob/master/fabfile.py#L55 and here is the code that fetches them: https://github.com/fikovnik/ShiftIt/blob/master/fabfile.py#L142 https://github.com/fikovnik/ShiftIt/blob/master/fabfile.py#L142 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/fikovnik/ShiftIt/issues/273#issuecomment-370472725, or mute the thread https://github.com/notifications/unsubscribe-auth/AADRIdgutj49vSGt2LSK2VCfubhUi775ks5tbWTrgaJpZM4STeki.
That I don't know. In the appcast you should see the location of the release notes. Perhaps the problem is that it somehow cannot fetch it / render it. Can it be feteched using curl?
What would the URL to used with curl be? I don't know anything about appcast.
-Roberto.
On Mar 5, 2018, at 12:13 PM, Filip Krikava [email protected] wrote:
That I don't know. In the appcast you should see the location of the release notes. Perhaps the problem is that it somehow cannot fetch it / render it. Can it be feteched using curl?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/fikovnik/ShiftIt/issues/273#issuecomment-370492187, or mute the thread https://github.com/notifications/unsubscribe-auth/AADRIUZwEGjmouvuy-UIIbShMYjn46p-ks5tbXI6gaJpZM4STeki.
I think the URL is wrong.
In appcast.xml there is:
<sparkle:releaseNotesLink>
http://htmlpreview.github.com/?https://raw.github.com/fikovnik/ShiftIt/master/release/release-notes-1.6.6.html
</sparkle:releaseNotesLink>
If I try it:
$ curl 'http://htmlpreview.github.com/?https://raw.github.com/fikovnik/ShiftIt/master/release/release-notes-1.6.6.html'
<html>
<head><title>301 Moved Permanently</title></head>
<body bgcolor="white">
<center><h1>301 Moved Permanently</h1></center>
<hr><center>nginx</center>
</body>
</html>
$ curl "https://raw.github.com/fikovnik/ShiftIt/master/release/release-notes-1.6.6.html"
# nothing
$ curl 'https://raw.githubusercontent.com/fikovnik/ShiftIt/master/release/release-notes-1.6.6.html'
<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
<html>
<body>
<h1>ShiftIt version 1.6.6</h1>
More information about this release can be found on <a href="https://github.com/fikovnik/ShiftIt/issues?milestone=8">github</a>.
<br/><br/>
If you find any bugs please report them on <a href="http://github.com/fikovnik/ShiftIt/issues">github</a>.
</body>
</html>
It seems that the URL serving raw content from github has changed. Sorry for not spotting it before.
