code-connect icon indicating copy to clipboard operation
code-connect copied to clipboard

Private github enterprise

Open cgatian opened this issue 9 months ago • 5 comments

Our org uses a private Github Enterprise instance. The code checks look like they fall through to the final statement:

Unsupported remote URL

https://github.com/figma/code-connect/blob/cfed2bf6f63c5d61d9d358556d3a7117ba9c59ba/cli/src/connect/project.ts#L507-L527

To quiet the message, I modified my config to only include figma.tsx files.

    "include": ["src/components/**/*.figma.{tsx,jsx}"],

This at least makes the files publish but now I'm getting warnings about resolving the component.

Import for Button could not be resolved, make sure that your `include` globs in `figma.config.json` matches the component source file (in addition to the Code Connect file). If you're using path aliases, make sure to include the same aliases in `figma.config.json` with the `paths` option.

😕 Confused about what the correct setup is for this situation.

cgatian avatar Mar 14 '25 13:03 cgatian

We are suffering from the same issue. is there a reason its trying to connect to github to begin with?

shmuelpro avatar Mar 23 '25 12:03 shmuelpro

Hey all! Thanks for the report and for digging into the error! For context we use the source field to be able to show clickable links the UI (screenshot below). We don't have any means today of supporting this for custom domains but are looking into our options.

Image

slees-figma avatar Mar 26 '25 10:03 slees-figma

Hey! We've added a fallback that should work for GH enterprise instances in 1.3.2 that we just released. Feel free to re-open this if you're still having this issue after upgrading.

karlpetersson avatar Apr 04 '25 17:04 karlpetersson

@karlpetersson I don't know what magic you did, but it's working properly now! 🎊

I think text next to the icon is missing? Maybe something on the rendering Dev Mode side? Clicking the company logo brings me to the proper code file in Github.

Image

cgatian avatar Apr 04 '25 19:04 cgatian

Hey @cgatian, yeah it looks like we missed something here. Will let you know when this is fixed!

karlpetersson avatar Apr 24 '25 11:04 karlpetersson