Denis Gukov

Results 416 comments of Denis Gukov

Endpoint `/endpoint` should be joined to project like `/projects/1/integrations/endpoint` because Semaphore can have a lot of users and projects (for example we have [Semaphore Cloud](https://cloud.semui.co)). So `GetAllIntegrationExtractors` can return a...

Also we should add request verification by token or secret: * for GitHub: https://docs.github.com/en/webhooks/using-webhooks/validating-webhook-deliveries * for GitLab: https://docs.gitlab.com/ee/user/project/integrations/webhooks.html#validate-payloads-by-using-a-secret-token

> The cloud offering wasn't in scope for me. Thanks for pointing that out. The projects/ subpath wouldn't require authentication though, correct? Yes, it is correct. Just URL will be...

Sorry to long delay. Thanks a lot for your work. Currently the PR is not compatible with the code. I closing it. Can you create new PR? If not, I...

@pavlozt do you still use Semaphore?

Hi @feedjosiah We already have Telegram, Slack, email alerts. I sure it is right way to support new messengers but we should refactor alert mechanism. We can't extend configuration file...

@feedjosiah it is good question... Setup process already too complex. I sure we should simplify it but not complicate. I think we should remove messengers configuration from setup process.