fieldtrip
fieldtrip copied to clipboard
fieldtrip
do not recompute lf if already existing
this relates to the issue #2188 after the dipole scan, the leadfield should be recomputed only if not already existing
You should test whether your modifications do not break anything. See https://www.fieldtriptoolbox.org/development/testing/
When outside the DCCN, please consider testing: test_ft_dipolefitting, test_example_simulate_forward_dipolefit, test_pull1377b
When inside the DCCN, please also consider testing: test_bug3119, test_eeglab_ft_integration, test_pull1377b, test_bug2773
Suggested tests outside the DCCN use public data or do not use data. Suggested tests inside the DCCN use private data.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
You should test whether your modifications do not break anything. See https://www.fieldtriptoolbox.org/development/testing/
When outside the DCCN, please consider testing: test_ft_dipolefitting, test_example_simulate_forward_dipolefit, test_pull1377b
When inside the DCCN, please also consider testing: test_bug2773, test_eeglab_ft_integration, test_bug3119, test_pull1377b
Suggested tests outside the DCCN use public data or do not use data. Suggested tests inside the DCCN use private data.
You should test whether your modifications do not break anything. See https://www.fieldtriptoolbox.org/development/testing/
When outside the DCCN, please consider testing: test_ft_dipolefitting, test_pull1377b, test_example_simulate_forward_dipolefit
When inside the DCCN, please also consider testing: test_bug2773, test_pull1377b, test_eeglab_ft_integration, test_bug3119
Suggested tests outside the DCCN use public data or do not use data. Suggested tests inside the DCCN use private data.
you are right, sorry. I now modified the code so that the corresponding leadfield is copied along the dipole, and there is a check on the field of of dipole. does it make sense to you now? thanks.
You should test whether your modifications do not break anything. See https://www.fieldtriptoolbox.org/development/testing/
When outside the DCCN, please consider testing: test_pull1377b, test_example_simulate_forward_dipolefit, test_ft_dipolefitting
When inside the DCCN, please also consider testing: test_pull1377b, test_bug2773, test_eeglab_ft_integration, test_bug3119
Suggested tests outside the DCCN use public data or do not use data. Suggested tests inside the DCCN use private data.
Hi @mcpiastra, have you tried to run the suggested test functions on your end (given the changed code)? Let me know if those functions ran through without error, then I will merge.
You should test whether your modifications do not break anything. See https://www.fieldtriptoolbox.org/development/testing/
When outside the DCCN, please consider testing: test_example_simulate_forward_dipolefit, test_pull1377b, test_ft_dipolefitting
When inside the DCCN, please also consider testing: test_bug3119, test_eeglab_ft_integration, test_pull1377b, test_bug2773
Suggested tests outside the DCCN use public data or do not use data. Suggested tests inside the DCCN use private data.
hi @schoffelen, after the last commit, yes, all the suggested tests run with no error. thanks!
Hi @mcpiastra I think that there is not much work to be done on this anymore. In other words, I think it can be merged, but it would be great if this PR also includes a snippet of test code added to a relevant test function (or a new test function altogether). Do you have some code lying around that allows for testing the functionality, or could you write some?
Hi @schoffelen , actually I was recently having the same question. What shall I do? Write a short script where this is used, with a dummy leadfield?
Well, indeed it would be good to have a snippet of code (either in an appropriate already existing test function, or in a new test function), that just goes through the movements. This would mean a call to ft_dipolefitting with a precomputed leadfield, with gridsearch = 'yes', and without the nonlinear optimization step. If it runs through without error, you're done.
You should test whether your modifications do not break anything. See https://www.fieldtriptoolbox.org/development/testing/
When outside the DCCN, please consider testing: test_pull1377b, test_example_simulate_forward_dipolefit, test_ft_dipolefitting
When inside the DCCN, please also consider testing: test_pull1377b, test_eeglab_ft_integration, test_bug3119, test_bug2773
Suggested tests outside the DCCN use public data or do not use data. Suggested tests inside the DCCN use private data.
You should test whether your modifications do not break anything. See https://www.fieldtriptoolbox.org/development/testing/
When outside the DCCN, please consider testing: test_example_simulate_forward_dipolefit, test_pull1377b, test_ft_dipolefitting
When inside the DCCN, please also consider testing: test_eeglab_ft_integration, test_bug3119, test_pull1377b, test_bug2773
Suggested tests outside the DCCN use public data or do not use data. Suggested tests inside the DCCN use private data.
You should test whether your modifications do not break anything. See https://www.fieldtriptoolbox.org/development/testing/
When outside the DCCN, please consider testing: test_example_simulate_forward_dipolefit, test_ft_dipolefitting, test_pull1377b
When inside the DCCN, please also consider testing: test_bug2773, test_bug3119, test_eeglab_ft_integration, test_pull1377b
Suggested tests outside the DCCN use public data or do not use data. Suggested tests inside the DCCN use private data.