Cura-LinearAdvanceSettingPlugin icon indicating copy to clipboard operation
Cura-LinearAdvanceSettingPlugin copied to clipboard

Update Readme to reflect new Klipper syntax

Open soxhi8 opened this issue 2 years ago • 3 comments

Klipper received a breaking change on setting default parameters lately, so the macro needs to be updated. https://github.com/Klipper3d/klipper/issues/4864

soxhi8 avatar Jan 22 '22 20:01 soxhi8

Does this need a note about which versions of Klipper need which syntax, or does the new syntax work for all versions?

fieldOfView avatar May 15 '22 13:05 fieldOfView

I will check compatibility for older versions and report back once I know more.

soxhi8 avatar May 18 '22 20:05 soxhi8

I can confirm the proposed syntax should have no issues in any documented Klipper version that supports macros. Anything prior to this wouldn't be relevant anyway.

If it's helpful, to avoid macros and resolve other compatibility issues like multiple extruders, I remixed your work into an unofficial PressureAdvanceSettingPlugin for Klipper only. I've continued development for my own curiosity but some of my changes might help if you decide to focus on Klipper support. It may not be worth it but perhaps a Klipper Firmware Support sub-setting would be a workaround to getting this fully compatible, unless you convince the devs to add a klipper g-code flavor :).

jjgraphix avatar Jun 04 '22 04:06 jjgraphix

I don't know why I never merged this, but better late than never, I guess.

fieldOfView avatar Mar 20 '23 13:03 fieldOfView

I don't know why I never merged this, but better late than never, I guess.

You were likely waiting for more confirmation on compatibility on older versions of Klipper, which I did not get around to testing in detail. But as jigraphix said, it should not be an issue. Thanks for merging!

soxhi8 avatar Mar 20 '23 15:03 soxhi8