laravel-eloquent-join icon indicating copy to clipboard operation
laravel-eloquent-join copied to clipboard

Laravel 9

Open kennyturner opened this issue 3 years ago • 4 comments

Have forked and updated to Laravel 9. Not many changes. However the tests will not complete and now seem to be outdated. Not sure if this package is still supported or if i should look for another solution.

Thanks

kennyturner avatar Feb 16 '22 13:02 kennyturner

I just submitted PR #120 that fixes the tests and updates the code accordingly. Hopefully the owner sees and merges this.

mikebronner avatar Feb 22 '22 10:02 mikebronner

Thanks for giving it a try, i had the same issues with the tests not working. I changed the workflow locally and ll good but failed on github also. Hopefully will be fixed soon, as I like the package and saves alot of work. Hopefully will maintained for a bit longer.

kennyturner avatar Feb 22 '22 20:02 kennyturner

I just submitted PR #120 that fixes the tests and updates the code accordingly. Hopefully the owner sees and merges this.

I use your fork in a project. Hummmm. Howto access to fields on joined table withouth a with()? `$posts = Post::orderByJoin('category.name');

if(request()->get('date')){ $posts->where('posts.date', $date) }

$posts = $posts->get();`

In this case $posts only have Posts fields and a field "sort" with name (it's possible getting sort field with alias? ex: name), but not the other Category fields (ex: category's created_at field). Adding "with" to include, generate another SQL query.

fhprietor avatar Jun 01 '22 11:06 fhprietor

Hello, some update here?

oksim14 avatar Jun 13 '22 11:06 oksim14

done!

fico7489 avatar May 15 '24 09:05 fico7489