Thanet Knack Praneenararat

Results 64 comments of Thanet Knack Praneenararat

I'm sorry that this was off my radar. Thanks so much for sharing your thoughts. We still keep this feature request for now, but frankly speaking, I don't have bandwidth...

https://github.com/googleapis/gapic-generator-php/issues/453 is already marked closed, so I'm closing this. Now, the classes are generated with `parseName()` functions available in some key classes since [v19.2.0](https://github.com/googleads/google-ads-php/releases/tag/v19.2.0) Overall, they may not be exactly...

With https://github.com/googleads/google-ads-php/pull/922 implemented and the fewer occurrences of the conflicts of grpc and protobuf versions between this library's dependencies, I think this can be resolved now.

The feature request is already complete, so I close this issue.

Fixed with [v20.1.0](https://github.com/googleads/google-ads-php/releases/tag/v20.1.0)

Edited: Thanks for reporting. It looks like what you reported is different from the previously reported issue. This one is about making the `GoogleAdsClient` final, but from what you said,...

Based on our [current documentation](https://developers.google.com/google-ads/api/docs/client-libs/php/fieldmasks#clearing_fields), this works as intended. With the limitations of the language and underlying protobuf, there is no perfect way that we can do this automatically as...

Hello Robert, Yes, creating an issue there would be great. We might get some insight why they designed it that way. Please also add the issue you'll create here, so...