fibercryptowallet icon indicating copy to clipboard operation
fibercryptowallet copied to clipboard

Full support for BIP44 in Wallet interface

Open olemis opened this issue 4 years ago • 0 comments

Feature description

Full support for BIP44 in Wallet interface

Is your feature request related to a problem? Please describe. It is not possible to cover the complete address space of a given BIP44 wallet

Describe the solution you'd like Modify signature of some methods so as to consider all parameters involved in BIP44 address generation. In this approach there is a single wallet object with methods receiving potentially infinite account indices .

Additional context For the moment SkyFiber plugin must only support account=0. Attempts to use a different index shall return invalid account index error .

Describe alternatives you've considered The current approach works from BIP44 account' node moving down the hierarchy . Nonetheless it leads to unnecessary object explosion due to potential use of infinite accounts , each of those hence requiring a separate object and memory space.

Possible implementation

  • [ ] Add account index and account type parameters in Wallet.GetLocalAddresses
  • [ ] Add account index parameter in Wallet.GenerateAddresses()
  • [ ] Add CRUD methods in Wallet interface for account names
  • [ ] Implement aforementioned methods in SkyFiber plugin

olemis avatar Oct 15 '19 17:10 olemis