fiaxh

Results 72 comments of fiaxh

> Dino's existing settings seem a bit sparse, though. Is this a big enough change that we want to add a setting for it? Playing animations seems to be an...

Thanks for the PR. This implementation has some issues: - The conversation object is a representation of the database and shouldn't be used to pass around temporary variables - The...

In order to keep the discussions around this PR in one place: There was an exchange on this topic in the Dino Channel a while back. mar-v-in suggested that it...

Thanks for your PR. I feel that this approach clutters this dialog with a lot of text, color and details that might be too specific for an overview dialog. Especially...

Please compile your code and test it before submitting it - this code doesn't even compile. It also needs lots of cleanup, for example you shouldn't add random commented-out code.

Thanks for your PR. Did you test this change with legacy bookmarks (xep 0048) or bookmarks2 (xep 402)? I see one issue with this change in combination with the [`add_conference`...

With this change, people that use laptops with touch screens would not be able to select text anymore. Also, setting `selectable=false` might also not be what you want on mobile...

> but for now this hack has worked fine for me. As I just mentioned, it breaks text selection on laptops with touch screens. This is a blocker for merging.

Thanks for looking into this. There are some issues: - A new Timeout is added whenever a stream is negotiated and they are not cancelled when the stream is broken....

Thanks for your PR. Adding a way to close a conversation on touch devices is a good idea. However, I'd like to put it into a different place: Make the...