nos2x icon indicating copy to clipboard operation
nos2x copied to clipboard

dismiss all pending dialog requests

Open eskema opened this issue 2 years ago • 8 comments

right now, everytime there's a window.nostr.nip04.decrypt, it opens a dialog and we have to go one by one. It would be better to have an option to act on all requests at once, otherwise, this can be very painful in the future if there's a high number of messages to decrypt.

eskema avatar Jun 12 '22 10:06 eskema

There is a button "forever" but it doesn't prevent a popup-flood the next time around, so I'm not sure what it does. Or maybe the plugin falls victim to my "delete all cookies when I close the browser" setting?

Giszmo avatar Sep 13 '22 17:09 Giszmo

I think this happened if you didn't already have a permissions object saved and you try to set permissions for new host. just ran into this and making pr now.

as far as 'forever' is concerned, you can only have one permission at a time per host it seems. is of you say authorize reading pubkey forever, but then say authorize decrypting messages for 5 min, the later permission will overwrite the former.

@fiatjaf would you be interested in me updating permissions to be level specific per host?

monlovesmango avatar Dec 15 '22 21:12 monlovesmango

@eskema can you confirm this is fixed for you now? if so should we close this issue? make sure your nos2x extension is updated to 1.5.2

monlovesmango avatar Dec 15 '22 23:12 monlovesmango

I did a quick test, and I still get one dialog popup per message on the first run.

eskema avatar Dec 16 '22 01:12 eskema

you using firefox or chrome? works for me on chrome.

monlovesmango avatar Dec 16 '22 02:12 monlovesmango

@eskema are you still experiencing this? I haven't had it happen since the fix.

monlovesmango avatar Jan 22 '23 23:01 monlovesmango

@eskema are you still experiencing this? I haven't had it happen since the fix.

I haven't been messing with kind-4 so don't really know if it's resolved.. feel free to close this if you think it's resolved, as I don't think i'll use the same method anyway and I should be able to avoid this even if not resolved..

eskema avatar Jan 22 '23 23:01 eskema

It is not resolved.

fiatjaf avatar Jan 23 '23 00:01 fiatjaf