fiaas-deploy-daemon icon indicating copy to clipboard operation
fiaas-deploy-daemon copied to clipboard

Published 20 hours ago • verified publisher icon fiaas

Remove code-path for responding to Delete events

Open gregjones opened this issue 4 years ago • 4 comments

Now that we are setting ownerReferences on the created objects kubernetes will take care of deleting them for us when the application is deleted, so we can remove all the code related to that.

The delete methods for service, ingress and autoscaler are still needed for the case where the config changes such that they are no longer required, but now they can be private/internal methods.

gregjones avatar May 28 '20 13:05 gregjones

@oyvindio Yes, I missed that part. It's deleted with 5b79aa54f978d4ef650ae0db1c59e8e376edf453

gregjones avatar May 29 '20 09:05 gregjones

Thanks for the reviews. As mentioned elsewhere, I'll wait on merging this until we are ready to trigger re-deploys of the apps in our clusters, I think it's relatively harmless being there and doing nothing in the short-term.

gregjones avatar May 29 '20 12:05 gregjones

Would be nice to just get this merged and out of the way, wouldn't it? :slightly_smiling_face:

mortenlj avatar Oct 28 '21 18:10 mortenlj

I think this PR needs to be merged or closed.

mortenlj avatar Jan 12 '23 09:01 mortenlj