vite-plugin-checker icon indicating copy to clipboard operation
vite-plugin-checker copied to clipboard

[email protected] breaks biome support

Open gkiely opened this issue 11 months ago • 6 comments

Describe the bug

This latest update broke a checker using biome

Reproduction

export default defineConfig({
  plugins: [
    checker({ typescript: true, biome: { command: 'lint' } })
  ]
} 

Expected behavior

Should work as it previously did with 0.8.0

System Info

System:
    OS: macOS 12.7.6
    CPU: (10) arm64 Apple M1 Pro
    Memory: 1.52 GB / 32.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 22.12.0 - ~/.volta/tools/image/node/22.12.0/bin/node
    Yarn: 1.22.22 - ~/.volta/tools/image/yarn/1.22.22/bin/yarn
    npm: 10.9.0 - ~/.volta/tools/image/node/22.12.0/bin/npm
    bun: 1.2.2 - ~/code/youneedawiki/node_modules/.bin/bun
    Watchman: 2024.08.12.00 - /opt/homebrew/bin/watchman
  Browsers:
    Brave Browser: 130.1.71.123
    Chrome: 133.0.6943.99
    Edge: 133.0.3065.69
    Safari: 17.6
  npmPackages:
    vite-plugin-checker: ^0.9.0 => 0.9.0

Additional context

No response

Validations

  • [x] Read the docs.
  • [x] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.

gkiely avatar Feb 20 '25 21:02 gkiely

Would you provide a reproduction please, and some more info on what is broken?

Using this command in the playground of this module works fine for me.

danielroe avatar Feb 21 '25 12:02 danielroe

@danielroe Can you send me the playground link you're using with biome configured.

gkiely avatar Feb 22 '25 01:02 gkiely

https://github.com/fi3ework/vite-plugin-checker/tree/main/playground/biome-default

danielroe avatar Feb 22 '25 03:02 danielroe

Same here

JcPires avatar Feb 24 '25 14:02 JcPires

i’m happy to investigate, but i need a reproduction and more information, please šŸ™

danielroe avatar Feb 24 '25 14:02 danielroe

Same problem here. This is the output when saving a file after launch (file has no error) :

[Biome] Found 0 error and 0 warning

[TypeScript] Found 0 errors. Watching for file changes.

node:internal/event_target:1101
  process.nextTick(() => { throw err; });
                           ^
Error: spawn EBADF
    at ChildProcess.spawn (node:internal/child_process:421:11)
    at spawn (node:child_process:753:9)
    at Object.execFile (node:child_process:346:17)
    at exec (node:child_process:233:25)
    at file:///project/node_modules/vite-plugin-checker/dist/checkers/biome/cli.js:23:5
    at new Promise (<anonymous>)
    at runBiome (file:///project/node_modules/vite-plugin-checker/dist/checkers/biome/cli.js:22:10)
    at handleFileChange (file:///project/node_modules/vite-plugin-checker/dist/checkers/biome/main.js:85:52)
    at FSWatcher.<anonymous> (file:///project/node_modules/vite-plugin-checker/dist/checkers/biome/main.js:100:9)
    at FSWatcher.emit (node:events:507:28) {
  errno: -9,
  code: 'EBADF',
  syscall: 'spawn'
}

Node.js v23.2.0

Also on macos/M1.

I tried to make a minimal project for reproduction but it works while my project won't.

yanngdev avatar Mar 10 '25 08:03 yanngdev

Closing until a repro is provided.

gkiely avatar Oct 05 '25 19:10 gkiely

@yanngdev @gkiely Could you try to check out this PR and see if it works for you? It fixed the issue on my project: https://github.com/fi3ework/vite-plugin-checker/pull/590

npm i https://pkg.pr.new/vite-plugin-checker@590

melonmanchan avatar Nov 12 '25 09:11 melonmanchan