vite-plugin-checker icon indicating copy to clipboard operation
vite-plugin-checker copied to clipboard

feat: add Stylelint basic support

Open ModyQyW opened this issue 3 years ago • 4 comments

https://github.com/fi3ework/vite-plugin-checker/issues/57

Mostly based on the eslint checker.

Tell me if I missed anything. Thanks. :D

ModyQyW avatar Jul 24 '22 14:07 ModyQyW

Deploy Preview for vite-plugin-checker canceled.

Name Link
Latest commit 10438b55869116a27a05df75a2f5365d539b3436
Latest deploy log https://app.netlify.com/sites/vite-plugin-checker/deploys/63479d855ba3f7000741a137

netlify[bot] avatar Jul 24 '22 14:07 netlify[bot]

Thanks! great work. The code LGTM mostly although we need to add test case afterwards. We need to add colorMap of diagnostic in the UI of stylelint here.

https://github.com/fi3ework/vite-plugin-checker/blob/dca415728218f6936fa71dc4b444e01fcdfd5c54/packages/runtime/src/components/Diagnostic.svelte#L6-L9

fi3ework avatar Aug 06 '22 12:08 fi3ework

Thanks for pointing out!

I just update some docs and update checkerColorMap. I use #ffffff (white) as stylelint color, since stylelint's icon includes only black and white and black is not clear enough.

ModyQyW avatar Aug 07 '22 03:08 ModyQyW

Just merged main branch and do some updates.

ModyQyW avatar Aug 29 '22 05:08 ModyQyW

Any updates? Can't wait to see this feature implemented 😃

amstiel avatar Oct 04 '22 09:10 amstiel

Just merged main branch.

ModyQyW avatar Oct 09 '22 10:10 ModyQyW

LGTM, still needs to resolve a conflict due to the update of package.json yesterday, and it can be merged.

fi3ework avatar Oct 10 '22 14:10 fi3ework

It is ready to be merged.

image

ModyQyW avatar Oct 10 '22 23:10 ModyQyW

Weird, I can't click merge button on the website and still got a conflict hint 🤔 image

I think the reason is the commits are separated in the commit history that can't be rebased by GitHub. Some squash or cherry-pick might be required.

image

fi3ework avatar Oct 12 '22 15:10 fi3ework

Try to do a rebase just now.

ModyQyW avatar Oct 13 '22 05:10 ModyQyW

Thanks, great work!

fi3ework avatar Oct 13 '22 15:10 fi3ework

❤️

ModyQyW avatar Oct 14 '22 00:10 ModyQyW