code128 icon indicating copy to clipboard operation
code128 copied to clipboard

Fix fnc3 and win versioning

Open gpongelli opened this issue 2 years ago • 4 comments

  • some codes that start with FNC3 returns "Invalid character in string"
  • add version number to Windows build

gpongelli avatar Mar 29 '23 13:03 gpongelli

Hi @gpongelli! Do you have an example of a string that fails?

fhunleth avatar Mar 29 '23 16:03 fhunleth

sure! take a look at this barcode image you can find it into the QuickScan QD2200 Product Reference Guide, page 25. the label, expressed using this library's input, is [FNC3]RevA\r:

  • using the actual master's commit, the above string will exit with "invalid character in string" due this if block, even if estimate_length's return value is not zero
  • using this fix, the above string will correctly generate the label

gpongelli avatar Mar 29 '23 20:03 gpongelli

FYI this changes works only on windows.

on raspberry hw, I still get "Invalid characters in string".

gpongelli avatar Mar 30 '23 09:03 gpongelli

last commit fixes ARM execution (linux) and works also for x86 (windows).

gpongelli avatar Mar 30 '23 12:03 gpongelli