hsac-fitnesse-fixtures icon indicating copy to clipboard operation
hsac-fitnesse-fixtures copied to clipboard

ENH: Arguments for firefoxprofile

Open teunisv opened this issue 4 years ago • 3 comments

TLDR: FirefoxOptions instead FirefoxProfile

Main reason: we want to start firefox headless, for that we need access to arguments those are accessible in FirefoxOptions not FirefoxProfile and for more overal compatibility with chrome FirefoxOptions has my preference.

I know this cause issues for existing profile uses, but hope you will consider it anyway

teunisv avatar May 22 '20 12:05 teunisv

No backward compatibility issues would arise if FirefoxOptions would be supported in addition to and not instead of profile, correct?

I would favour a change that allows with options (also for chrome) to allow options to be specified...

fhoeben avatar May 22 '20 13:05 fhoeben

Yeah its backward compatible if you find a mechanisch to extinguish the two

I use "with profile" for chrome as well (example headless), this also works for mobile emulation

|script         |list fixture                                 |
|add            |headless                                     |
|add            |disable-gpu                                  |
|$args=         |copy list                                    |
|start          |map fixture                                  |
|set value      |$args   |for|args                            |
|set value      |false   |for|prefs.safebrowsing.enabled      |
|$chromeProfile=|copy map                                     |

|script          |selenium driver setup             |
|start driver for|chrome|with profile|$chromeProfile|

teunisv avatar May 22 '20 13:05 teunisv

Yes so that's why I though it would be good to support

|start driver for|chrome|with options|$chromeProfile|

(where its probably better to rename the variable to chromeOptions)

fhoeben avatar May 22 '20 13:05 fhoeben