html-to-json icon indicating copy to clipboard operation
html-to-json copied to clipboard

Add type annotations

Open fhightower opened this issue 4 years ago • 4 comments

We should add type annotations on all public interfaces in this library.

fhightower avatar Feb 27 '21 15:02 fhightower

Hey, @fhightower, I found recently your lib, because I wanted to create a fast script that can convert an XML/HTML response of a curl to a JSON format (curl <endpoint> | ./converter.py | prettyjson). Really useful lib, thanks !

I can help with the type annotations. I've used them in most of my python repos.

mlliarm avatar Nov 24 '22 17:11 mlliarm

Thanks for reaching out @mlliarm (and sorry about the slow response). Glad to hear it's useful!

That would be great if you can add type annotations (or even some type annotations would be helpful)! I'll assign this issue to you, but please reach out if you have any questions.

fhightower avatar Dec 02 '22 17:12 fhightower

Hello,

Apologies for stalling, but there was too much work in my dayjob.

I've already added the annotations in my fork, but correcting the unit test suite took some time, and wanted to have a full green pass from all the tests before sending the PR.

As I'm on holidays for the next 3 weeks and have the required time and energy, I'll try finishing both this issue and #16 within February.

Cheers

mlliarm avatar Feb 01 '23 12:02 mlliarm

Totally understand - I've been pretty slammed myself. Any contributions are appreciated and no rush!

fhightower avatar May 02 '23 14:05 fhightower