WIP: Prevent crash on WebSocket request to non-WebSocket node.
This provides a partial fix for #51 to prevent the Guru from having to meditate. It's been tested on ESP32.
This now checks the HTTPNode type if a WebSocket was requested and only proceeds if the node is in fact a WebSocket, thus preventing the newHandler() call from failing on normal HTTP nodes.
TODO
Right now I'm calling raiseError(404... because that was the first copypaste I can find. I'm not actually sure the best way to reject the websocket connection as I'm not familiar with this library (just picked it up yesterday). This code is sufficient to move the crash over to the client side, which reports a bad frame header now.
A proper rejection should be sent, however that is accomplished in WebSocket land.
Testing
-
Clone and run the WebSocket chat server example from the master branch, and use https://www.websocket.org/echo.html to connect to the root URL on the device. This should panic and reset your ESP32. Connecting to
/chatshould work as expected. -
Check out this PR and do the same. The ESP32 should no longer panic, and report the rejection of non-WebSocket request.