Felix Hanau

> This is more of a feature request than a bug. The spec does not require brotli support. > > That said, we actually do have this support, but it...

Hello Nathaniel, I think that's a good suggestion. I recently started using GitHub actions in a different project so I'm familiar with using it. For building on Windows, I generally...

ECT uses multithreading, but there are limitations to how many threads it can use based on the input data. `--mt-deflate` uses several threads to compress the different blocks in a...

A few more things can be removed – `c++/build/configure.bzl` still has a track_lock_blocking variable and the `Inherits from LockSourceLocation to perform an empty base class optimization when lock tracking...` comment...

Will take a look at this soon. Note that compression flushing is a can of worms – Zlib has a number of different flush options of which Z_SYNC_FLUSH should be...

LGTM – I reviewed the current implementation and the documentation for `Z_SYNC_FLUSH` and `BROTLI_OPERATION_FLUSH`, this approach should be correct. One style concern I have is that this requires external code...

> @fhanau : > > > ...One style concern I have is that this requires external code to specify Z_SYNC_FLUSH when using the gzip implementation > > That was intentional...

[build] Note that as of #2012 we no longer use a glob for the JSG source files in `src/workerd/jsg/BUILD.bazel` – you'll need to explicitly add `modules-new.c++` to the set, linking...

I went through the header and some of the tests, the API design looks good! Will continue reviewing this tomorrow.

LGTM otherwise! 😌 I didn't really see correctness issues in the implementation, perhaps the prior comments were already useful for that although we might find some later on. Looks well-designed...