Florian Hammerschmidt

Results 193 comments of Florian Hammerschmidt

Does it really need to execute on every PR or is that just for testing? Because the sync step takes 2.45 minutes and only the commit and push part is...

Ok I missed that part. I guess then it's totally fine.

Yes, this is still an issue and should be reopened IMO. Except if we really won't fix it which I do not hope for. cc @cristianoc @ryyppy @cknitt

It does not matter which Stdlib. Belt, Core and v12 Stdlib all use `parseInt` under the hood which does not return `NaN` for "12xxx3" either. ```js > console.log(parseInt("12xxx3")); 12 ```...

So now ReScript formats a lot of one-liners in our codebase into at least 4-liners, e.g. ```reason let clone = date => Js.Date.(date->getTime->fromFloat); ``` to ```reason let clone = date...

Maybe wrap stuff in "" if there are spaces between words, but trim the outer spaces away. Could be similar to how polymorphic variants do it. `#"hello world"`

Then still it would be better to just have a barebones template in Create-ReScript-App. Many people don't have a globally installed ReScript on their machine.

@shulhi do you think we can relax this a bit? I am not keen of adding a `@@format("off")` attribute.

I edited the initial example. Here's also playground link: https://rescript-lang.org/try?version=v12.0.0-rc.2&module=esmodule&code=AIWw9gJgrgNgpgCgETmvAGkglAAjgDwBc4AnAOwEMYcAzARgC4cBnMEOAFQE8AHOOnAF4AfCzadecAExCcSVuwBiUMgGMkAKA2hIsRCl0ZseIqUrUaUphTJhCAC1Lc+AkTgcBLEhGdxZ88QB5B1JlNU0NAHpInFUYD1UAa1owEhAKQhwbCFjHJJwwKEyQnHiyPwAjOBgwAHdtVD1kRqNcAmJyKloAZiYPMg64ZkJ+gHNfV1F+weGx3xlBOQU4MNUAdQ8HAEEAGTAyUdIAOQp2CJ00fRa4TDbTTosAFiZCSfcFuRs7RxJVzSA