Giveme5W1H icon indicating copy to clipboard operation
Giveme5W1H copied to clipboard

Published 20 hours ago • verified publisher icon fhamborg

Add Docker support for the server

Open AleksanderMako opened this issue 3 years ago • 3 comments

run the NLP server inside a docker container to make running the server practical

AleksanderMako avatar Jun 30 '21 17:06 AleksanderMako

thanks for your mail and the issue report - i just read this issue after getting your mail. could you let me know, what issues were you facing that made starting and running the corenlp server "impractical"? we do provide a simple command (see readme.md) to startup the server so im unsure how this is not practical. or did you face an issue when starting up the server?

fhamborg avatar Jul 01 '21 11:07 fhamborg

I had a few issues:

  1. I did not want to install jdk in my computer to run the server.
  2. The server has some dependency to wget and I did not want to install that either.
  3. There was a dependency on some unziping tool as well which I did not have and also did not want to install.
  4. I saw that you can change the port that the Giveme5W1H library tries to dial but I did not see how I could change it if I needed to. Maybe I did not look hard enough though for this particular case.
  5. This is more of a comment but ever since I managed to run the command you provide inside a container I have been able to reproduce the desired behaviour every time and I think in general Docker would provide some stability in running the server reliably.
  6. Lastly I am not saying I my way is the best way or that my Docker support is actually the best it could I put it together from wherever I could but just wanted to share an idea that might make the project better and easier to use :)

AleksanderMako avatar Jul 01 '21 16:07 AleksanderMako

I understand your comments. In general, I want to keep our repos as lean as possible, i.e., so that they focus on only the core functionality (which here is the 5W1H extraction). Only for convenience, we added this "download and run" command for the server. Having two ways of doing this function also means having two things to support and generally I try to avoid redundancy. However, in case the docker version is more convenient, I might add it and perhaps remove the current way Feel free to open a PR for me and my colleagues to have a look :)

fhamborg avatar Jul 02 '21 06:07 fhamborg