fhackenberger
(very WIP) KF6 port
At this point I’m basically just changing things until it compiles.
It does currently, but crashes with a “pure virtual method called” segfault on close, and I’m too bad with C++ to have an inkling about why that might be.
I’d be happy to help getting this into shape, but I’m also happy if you just take it as inspiration.
In #60 @alexfikl was saying they were wanting to port, a lot of code cleaning happened but I’m not sure where that porting effort lead to. Maybe there is some space for collaboration between the twos of you?
In #60 @alexfikl was saying they were wanting to port, a lot of code cleaning happened but I’m not sure where that porting effort lead to. Maybe there is some space for collaboration between the twos of you?
Unfortunately, I haven't had time to continue working on this after the general cleanups from a while back. My next item on the TODO list was porting to K_PLUGIN_CLASS_WITH_JSON, which doesn't seem included in here and I think the old K_PLUGIN_FACTORY was removed in KF6 (?).
I'm also not sure if it's desired to keep the codebase working on both Qt5 and Qt6 (before it was working on both Qt4 and Qt5). It definitely requires some discussion and planning :grin:
Original author here. I'm not sure if @jfmcarreira is still active, he was maintaining ktikz mostly. Maybe wait a few days to give him a chance to reply. If he doesn't, I'd say if you are up for moving forward @alexfikl feel free to. Supporting two versions of Qt is nice, but given the maturity of the application, I'd argue its fine to only support the latest version for new releases, if that makes development easier. Security fixes can then still be backported. If you need repository permissions, just shoot me an email. Thank you for your contributions!
I would agree that it might be easy moving foward to keep only Qt6 support. I believe the application is mature enough and not seen new features appearing that it is deal breaker to keep the current version if you dont have Qt6 available.
Sorry for not following along. Nowadays, I do not use ktikz as often as I used to, and not using Linux on my daily driver is hard to keep mantaining it.
@flying-sheep Hello could you please remove the vscode project files from the PR.
I will try to test and give you some feedback on the PR
Original author here. I'm not sure if @jfmcarreira is still active, he was maintaining ktikz mostly. Maybe wait a few days to give him a chance to reply. If he doesn't, I'd say if you are up for moving forward @alexfikl feel free to. Supporting two versions of Qt is nice, but given the maturity of the application, I'd argue its fine to only support the latest version for new releases, if that makes development easier. Security fixes can then still be backported. If you need repository permissions, just shoot me an email. Thank you for your contributions!
Thank you for the kind words! I still use ktikz quite often, so I would very much like to see it stick around (thus my initial burst last year to get it closer to Qt6). I'm not a C++/Qt developer though, so I'm not very confident I can help much with maintaining / fixing bugs :(
Hello, I can try integrate this and see if I could find the segfault problem (is it still a problem?)
However, as I am not a daily user of this app and not using linux as a daily driver, it is being hard to keep up with recent changes in KDE.
I might need help maintaining this repo. maybe @fhackenberger could give permission for others to push code.
Hopefully temporarily! The KTextEditor-base build is the only one I care about.