node-bacstack
node-bacstack copied to clipboard
fix for writeProperty fail
Checklist
- [x] I've read and followed the Contribution Guide.
- [x] My commit messages reference affected issues and mention breaking changes if applicable.
- [x] I've updated / wrote inline documentation for the source code affected by my changes.
- [x] All mandatory CI checks have passed (see when Pull Request has been submitted).
Open Question
What does this Pull Request do
I was facing the same issue as described in #138.
I digged in and found that in the writeProperty
function, if no priority
in the optional options
object is set the value will be undefined and then not set in the protocol.
Speaking of this function:
https://github.com/fh1ch/node-bacstack/blob/9e193103d2ae41cbaf7e28dcdcd5bc31c8e0e1e8/lib/client.js#L615
Here a test with priority in options
set (left side) and without (right side).
So I was about to create a PR to fix it but luckely I came across this PR and saw that it already has 😄
Therefore just wanted to confirm that this PR solves #138 😉