fguillen
Added mime_type for metadata method response
Hello Artur,
Can you add a few tests (or modify any of the actual tests) to check this changes?
sure will do this at the evening or during the weekend, cuz have a lot of work now. btw. thanks for sharing this gem, it saved me a lot of work :)
On Thu, Sep 22, 2011 at 12:14 PM, Fernando Guillen < [email protected]>wrote:
Hello Artur,
Can you add a few tests (or modify any of the actual tests) to check this changes?
Reply to this email directly or view it on GitHub: https://github.com/fguillen/DummyDropbox/pull/1#issuecomment-2165909
On Thu, Sep 22, 2011 at 12:45 PM, Artur [email protected] wrote:
sure
Perfect!
will do this at the evening or during the weekend, cuz have a lot of work now.
Take your time, and don't put to much work on it, just a test checking that the new metadata attributes are there, and the values are consistent.
As you see the tests are very simple:
- https://github.com/fguillen/DummyDropbox/blob/master/test/dummy_dropbox_test.rb
btw. thanks for sharing this gem, it saved me a lot of work :)
I'm glad to know :)
f.
Fernando Guillén Freelance Web Developer http://www.fernandoguillen.info http://spainrb.org/fernando-guillen
Artur,
Also it would be helpful to 'squashing' all your commits in only one and send the pull request in only one commit.
This last point is not important so if you have a reason for making this modification in multiple commits is alright for me.
f.
On Thu, Sep 22, 2011 at 1:13 PM, Fernando Guillen [email protected] wrote:
On Thu, Sep 22, 2011 at 12:45 PM, Artur [email protected] wrote:
sure
Perfect!
will do this at the evening or during the weekend, cuz have a lot of work now.
Take your time, and don't put to much work on it, just a test checking that the new metadata attributes are there, and the values are consistent.
As you see the tests are very simple:
- https://github.com/fguillen/DummyDropbox/blob/master/test/dummy_dropbox_test.rb
btw. thanks for sharing this gem, it saved me a lot of work :)
I'm glad to know :)
f.
Fernando Guillén Freelance Web Developer http://www.fernandoguillen.info http://spainrb.org/fernando-guillen
Fernando Guillén Freelance Web Developer http://www.fernandoguillen.info http://spainrb.org/fernando-guillen