perfect_dark icon indicating copy to clipboard operation
perfect_dark copied to clipboard

Allow users to set up more than one Laptop Gun sentry

Open blaiz opened this issue 1 year ago • 9 comments

Here's a draft PR to allows users to set up up to 1000 sentry guns instead of just one. This can be fun in multiplayer, where you can have a level covered with sentries everywhere.

This is a draft PR just to gauge interest. If this is something we'd want, this would likely need to be a setting somewhere, or potentially a cheat. I'm not sure how that would work since the game allocates memory for a certain number of sentries, so I don't know how to make that dynamic yet but I can spend a bit of time and figure that out if there's interest.

As it currently is, this game works well most of the time but the game does crash sometimes.

Screenshot 2023-11-20 002111

Screenshot 2023-11-24 185652

blaiz avatar May 20 '24 06:05 blaiz

To be honest, I think 10 is more than sufficient. :P

FrostKnight avatar Oct 02 '24 05:10 FrostKnight

You haven't met my kid 😀 Unfortunately I think this change makes the game crash randomly every once in a while.

blaiz avatar Oct 02 '24 06:10 blaiz

You haven't met my kid 😀 Unfortunately I think this change makes the game crash randomly every once in a while.

I still feel like there should be a limiter option for this lol.

FrostKnight avatar Nov 13 '24 01:11 FrostKnight

Someone tell me when this is added to a new stable, this has my interest. :)

FrostKnight avatar May 08 '25 23:05 FrostKnight

I'm sorry to say, I don't think this will ever be added to stable because it has a huge potential for instability and crashes, unless someone wants to take the time to debug it properly. In the meantime you can clone the repo, then cherry-pick this commit in a new branch and build that to use it.

Would that remain true if it was limited to anything under 4? The number of laptops being limited to say, only 3?

How many laptops could you have the limit be at and still have crashes but very rare like the stable.

20? 10? less than 10? Curious

FrostKnight avatar May 09 '25 22:05 FrostKnight

That's a good question. It would require enough testing to convince the maintainer that it can be merged into the port branch. In the meantime I'd recommend building your own copy of the game. Let me know if you need help doing that.

blaiz avatar May 10 '25 05:05 blaiz

That's a good question. It would require enough testing to convince the maintainer that it can be merged into the port branch. In the meantime I'd recommend building your own copy of the game. Let me know if you need help doing that.

Your build is too far back, its like 300 commits behind.

Also, I think 1000 is a bit nuts personally. That is asking for crashes lol.

I am not into 1000, maybe like at most 10?

Just sayin... I think trying for a lower number than 11 like 10 or less, would make it less crash prone. Just a guess but 1000 sounds too damn crazy.

Actually, make it 5 and an optional experimental setting that can be turned on in advanced with a "could be buggy" warning next to it

FrostKnight avatar May 10 '25 07:05 FrostKnight

What I mean is you can clone the current repo here locally, create a new branch, git cherry-pick 13a415a68207da9a98b5a4eff6e5307db0ad510d from my repo, tweak it to be 10 instead of 1000 and you're good to go. And yes 1000 is crazy, 10 is more reasonable. There's probably a way to put this behind a setting in the Extended menu, even potentially make it dynamic and controllable in the UI or something but I don't have the expertise nor the time to do that at the moment. Maybe someday.

blaiz avatar May 10 '25 08:05 blaiz

What I mean is you can clone the current repo here locally, create a new branch, git cherry-pick 13a415a from my repo, tweak it to be 10 instead of 1000 and you're good to go. And yes 1000 is crazy, 10 is more reasonable. There's probably a way to put this behind a setting in the Extended menu, even potentially make it dynamic and controllable in the UI or something but I don't have the expertise nor the time to do that at the moment. Maybe someday.

Recommendation for commands to run?

Just asking, because I don't know how I would do this.

FrostKnight avatar May 19 '25 16:05 FrostKnight