openmw icon indicating copy to clipboard operation
openmw copied to clipboard

switch: show username as default for character name

Open terabyte25 opened this issue 5 years ago • 4 comments

terabyte25 avatar Jun 07 '19 22:06 terabyte25

What if someone's username is "global". Maybe we should make getUsername return "" if it couldn't be obtained and just check it in the path functions.

fgsfdsfgs avatar Jun 08 '19 15:06 fgsfdsfgs

What if someone's username is "global".

You could argue the same for any other default username.

terabyte25 avatar Jun 08 '19 15:06 terabyte25

That's true, which is why I'm offering to return an empty string instead. Saves can still go in global, since that's not much of a problem.

fgsfdsfgs avatar Jun 08 '19 15:06 fgsfdsfgs

Sounds good to me then, I'll revert the last commit in this PR if you push those changes.

terabyte25 avatar Jun 08 '19 15:06 terabyte25