Friedrich Große
Friedrich Große
I ended up mentioning this under ["Limitations" in the README.md](https://github.com/fgrosse/go-coverage-report?tab=readme-ov-file#limitations) . Thanks again for pointing out this issue and helping to debug it.
GitHub actions artifacts by default expire after 90 days (which is also the maximum).
Sure, go for it 😃
Yes that would be great. I currently only have very limited time to maintain projects on GitHub. :)
@findleyr : let's continue the discussion from https://github.com/modelcontextprotocol/go-sdk/issues/479#issuecomment-3303117327 here: I agree to all points and implemented the feedback via c999042ddd73f9bea234582f7649a34b7fcf9ecf Now I'm playing with he idea of adding an `OnNewSession`...
So, the `OnNewSession(*ServerSession)` hook + `session.Wait()` in a goroutine would work. However, it pushes extra complexity on the caller to deal with the added goroutine. E.g., my own server now...
I see tests are hanging and then eventually timed out. I saw the same flaky issue already on the **main branch**. Every once in a while tests seem to run...
Using https://github.com/uber-go/goleak on `main` I see there is at least an issue with leaking goroutines in tests. The first indicator for that was the high amount of goroutines in the...
@findleyr , can you try triggering the failing CI jobs, just to see if its a flake?
You are right - the issue was on the branch and I fixed it via f3b5d9367bed69076e6a38880fa1d736ea08bc82 It was a surprisingly subtle issue in the order of teardown for `TestStreamableTransports` which...