go-dockerpty icon indicating copy to clipboard operation
go-dockerpty copied to clipboard

General upgrade, Support for Windows

Open matthieudelaro opened this issue 9 years ago • 4 comments
trafficstars

Modifications:

  • upgrade the code in dockerpty.go from https://github.com/docker/docker/api/client/utils.go
  • include dependencies in vendor (docker/docker/pkg/signal, docker/docker/pkg/system, docker/docker/pkg/term, Azure/go-ansiterm)
  • add Sirupsen/logrus and fsouza/go-dockerclient as git submodule (those two are required by dependencies)

Compilation method used:

  • with Nut: nut build-all (compile for all platforms)
  • or in docker container, with image golang:1.6

Tests:

  • compilation pass on linux, macos, windows
  • tested on Linux and Windows as a dependency of Nut (branch supportwindows)
  • RUNITME NOT TESTED ON WINDOWS (I don't have the config)

Note:

  • folder ./term is replaced by vendor/github.com/docker/docker/pkg/term (where the original from docker came from)
  • packages from docker do not compile with latest version of Azure/go-ansiterm. So this one has not been added as a git submodule, but was taken from docker/docker/vendor

matthieudelaro avatar Apr 28 '16 08:04 matthieudelaro

Hey @matthieudelaro! Great work on this PR, thanks a lot!

I had a quick look around and the only thing that I'm not 100% sure about is the need to have a main.go (dockerpty is a library, its not expected to be compiled to an executable) and nut.yml on this project (I personally don't use the tool and the config references your fork of this project 😁 ) Do you mind removing them? 🍻

fgrehm avatar May 09 '16 14:05 fgrehm

Sure, here it is

matthieudelaro avatar May 25 '16 13:05 matthieudelaro

Hi @fgrehm,

I just landed on this old PR. How do you feel about merging this?

matthieudelaro avatar Jan 22 '18 08:01 matthieudelaro

Sorry but I don't have a need for this project anymore... Do u want to take it over? 🍻

fgrehm avatar Jan 23 '18 17:01 fgrehm