Forest Gregg

Results 351 comments of Forest Gregg

Generally, i really like this direction. Sorry for the slow response, i've been out sick.

With your refactor, it's pretty apparent that the weighted sampling methods on these classes are a bit odd. We can save that for a future PR though. Probably, the right...

hi @NickCrews. sorry for the slow response! I responded two to you on the `cover` change.

i'm going to go ahead and bring this in, and we can keep on working on improving how we interact with predicates in future PRs.

there's a few issues related to pickling either kind of object, and then some issues related to the differences between the objects. # Common issues * the indexes are not...

actually, ideal would be to track three things distinctly * track time training * track time matching if i trained * track time matching if i read from settings file

would love to have some bigger data sets. those would probably need to be run on demand or nightly to and on every push.

One challenge here is that the training data does not have unique ids.

Our current canonicalize method does not implement those things, but could.