meeteval icon indicating copy to clipboard operation
meeteval copied to clipboard

Missing dependency: simplejson

Open alexanderwerning opened this issue 1 month ago • 3 comments

meeteval.io.seglst.SegLST.parse requires simplejson, which is neither listed in the requirements.txt nor in the pyproject.toml.

alexanderwerning avatar Nov 07 '25 10:11 alexanderwerning

It is listed in the [cli] dependencies in setup.py. The reasoning was that you don't need to parse SegLST files if you don't use the CLI. I'm fine with moving it to the install_requires requirements.

thequilo avatar Nov 07 '25 10:11 thequilo

Ok, so there are three files with dependencies, setup.py requirements.txt and pyproject.toml? This is a bit confusing. If simplejson is not needed by the average user, we can keep it as an optional dependency.

alexanderwerning avatar Nov 21 '25 10:11 alexanderwerning

How about updating the readme install instructions?

pip install meeteval  # pip install meeteval[all]

boeddeker avatar Nov 21 '25 12:11 boeddeker

I think we can delete requirements.txt. setup.py was required for cython extensions. It may now be possible to build python extensions with just a pyproject.toml, but I haven't tested it yet. I'm also not sure whether all issues with pyproject.toml (e.g., editable installs) are completely resolved. So I think that it's better to stick to setup.py for now.

It makes sense to update the readme instructions

thequilo avatar Nov 22 '25 18:11 thequilo