fgnass
Repo maintenance
Hi,
I was wondering if there is interest in maintaining this repo any further? There are few good updates sitting in the PRs list and the NPM package is behind as well.
Recently I was looking for a stack trace remapper that could handle hidden source maps and this tool was the only one that did it for me. But it needed some tweaking (applying the updates to the package, etc.) so it made me think if I could help with this repo or if I shall go with a fork. Either way is fine for me but wanted to spare duplicating the project if possible.
And thank you for this useful tool :)
Thanks for offering your help! I've added you as collaborator. What's your npm username?
Thank you! My user name at NPM is gkostov
And regarding the existing tests, I have no experience or an account with Saucelabs so wanted to discuss the possibility of you running those (unless Sauce Labs runs the tests automatically on push to master) or maybe getting a set of unit tests that can be run locally (mocha or anything such). What do you think?
I've added you as maintainer on npm. The Saucelabs tests should run automatically as long as Travis CI still works (I'm not up-to-date regarding their shutdown plans).
I first added some examples in this branch https://github.com/fgnass/retrace/tree/examples . I prefer to have something that I can run instantly and check what's going on before I start to make changes to the main code. I believe I got to keep with the coding style in the existing files but in fact the referenced "[email protected]" fails with the .eslintrc in the repo so I wondered how much of a deal linting really is here :)
Anyway if the above looks alright so far then I'll merge the examples branch and will start with the updates to the main code.
Cheers
Feel free to update the code style to something more modern (it's six years old by now)! Maybe just "eslint:recommended" + prettier in its default config?
Due to a dependency update I had to up the version of node that the tests run on and got a fail here https://travis-ci.org/github/fgnass/retrace/jobs/765317082
And this seems the repeating error Error: connect ECONNREFUSED 127.0.0.1:4445. Do you have any guess?
If I read this correctly, in Sauce Connect >= 4.6 the proxy feature is disabled by default and the recommended way is now to connect to https://${user}:${key}@ondemand.saucelabs.com/wd/hub rather than localhost:4445.
Ok, that did it and it connects now but there are errors now while the tests execute. And not assertion errors but something which looks like incompatibility between what the code expects the remote to do and what the remote is doing https://travis-ci.org/github/fgnass/retrace/builds/765465049 ...
I may try to update wd and see what that yields.
Still no luck https://travis-ci.org/github/fgnass/retrace/builds/765598690
I don't have experience with Sauce/Selenium tests and I can't get any documentation to make it clear but I suspect that if the call wd.remote('https://${user}:${key}@ondemand.saucelabs.com/wd/hub'); is probably causing the tests to run on that remote host (ondemand.saucelabs.com) and then later in the file there is server.listen(8001, function() {... which potentially runs a server on the travis-ci.org machine, and then the tests running on ondemand.saucelabs.com will never reach the server by calling browser.get('http://localhost:8001/' + name + '.html', function() {. Could this be true? It's been all good with the old call wd.remote('localhost', 4445, user, key); causing both to run on the same machine, I think ...
Kept looking at this and got to a point where Sauce sent this error "The environment you requested was unavailable" together with "Uh oh, you've run out of minutes!" https://travis-ci.org/github/fgnass/retrace/builds/766119211 . I'll not be trying again soon and I hope that this has not been drawing from your personal account's fund.