Frederic Giloux

/remove-lifecycle stale

/remove-lifecycle stale

/remove-lifecycle rotten

(1) When we discussed it with @sttts I think that (1) was the preferred approach. By using Partitions service providers have the option to filter out Shards, hence VirtualWorkspaces they...

This looks good to me. I just have a couple of points: Can you please amend the comment here? https://github.com/kcp-dev/kcp/blob/73cc8efef729522a1dc30f1e7318559982817460/test/e2e/reconciler/apiexportendpointslice/apiexportendpointslice_test.go#L268-L270 This could be a separate test function: https://github.com/kcp-dev/kcp/blob/73cc8efef729522a1dc30f1e7318559982817460/test/e2e/reconciler/apiexportendpointslice/apiexportendpointslice_test.go#L342-L382 It was...

> Updated the comment. IMO there is no need for extracting logic to a helper function. I like when tests are self-contained and self-descriptive. I did not mean a helper...

Seconding the request here. I see the dependency as problematic: - cert-manager itself cannot be installed and upgrades / uninstall cannot be managed by OLM/RukPak - an existing version on...