Frederic Giloux
Frederic Giloux
> I think I'd like to see us add some testing around the filenames that get returned from the Load(...) method to ensure we don't regress on the registry side-of-things...
> I see a couple of pkg/lib/indexer/index.Dockerfile* changes that are present in this PR. Any idea what they're needed for, or were they generated locally, and we're not correctly filtering...
> Can we separate the go.mod + vendor changes into their own commit, so viewing the full diff is a bit easier? One of these days we'll remove the vendor...
Hi @timflannagan any further comment on this pull request?
@timflannagan after the API rebase we now have: the API depending on k8s.io/api v0.23.0 whereas OLM was on k8s.io/api v0.22.2 and breaks when the dependency is bumped. This was introduced...
> It looks like the CI failures are complaining about various breaking changes that happen in the v0.23.x kube dependencies. Yes it is what I was saying earlier. > We...
Hi @timflannagan based on o-f api v0.13.0 all e2e tests passed except 1. I ran it locally and it was successful. One thing is that I had to downgrade grpc...
@timflannagan @joelanford could you please take a look? I have rerun the failing e2e tests locally. "can satisfy an unassociated ClusterServiceVersion's non-ownership requirement" was successful. The other two were not:...