Sam Hulick

Results 191 comments of Sam Hulick

@chrisn I just noticed this: >Adding mousewheel scroll using the existing zoom API should be straightforward, and wouldn't require changes to Peaks.js. I'm not sure how this would've been possible...

Current progress below. I'm happy to open a PR and have people help hack on this! I'm sure it could be improved. But it's up to Chris how much of...

>This sounds good, but how have you handled default behaviour, which is to scroll the page? The `wheel` event is on the Konva stage. So as long as your mouse...

@chrisn Great tip on using `zoomview.setStartTime()`! I was able to move all of the scroll/zoom code outside of Peaks.js. ```vue ``` ```typescript zoomviewWheel(event: WheelEvent) { const zoomview = this.peaks.views.getView('zoomview'); if...

Let me know exactly which changes you want. I've made a new fork here: https://github.com/reelcrafter/peaks.js That fork, at this point in time, incorporates the following changes: * Mouse wheel/trackpad scroll...

I think we could have just one method to enable/disable wheel scrolling, instead of two. Maybe: ```ts zoom.setScrollMethod('drag' | 'wheel'); ``` I'm not too keen on the word "wheel" since...

@dutzi Glad you found it helpful!

@dutzi Yeah, I just found it a bit too choppy in some cases, especially the longer the waveform. It's not the end of the world if our customers have to...

What about libfaac?

@dutzi Unfortunately not, still an issue here - last time I checked, at least.