hana icon indicating copy to clipboard operation
hana copied to clipboard

use 32-bit ints for values, add NaN tagging

Open ffwff opened this issue 5 years ago • 2 comments

fixes #18

ffwff avatar Jun 03 '19 13:06 ffwff

Codecov Report

:exclamation: No coverage uploaded for pull request base (haru@ac5d6b8). Click here to learn what that means. The diff coverage is 80.67%.

Impacted file tree graph

@@           Coverage Diff           @@
##             haru      #21   +/-   ##
=======================================
  Coverage        ?   84.62%           
=======================================
  Files           ?       32           
  Lines           ?     2816           
  Branches        ?        0           
=======================================
  Hits            ?     2383           
  Misses          ?      433           
  Partials        ?        0
Impacted Files Coverage Δ
src/hanayo/time.rs 0% <0%> (ø)
src/vmbindings/function.rs 100% <100%> (ø)
src/vmbindings/value.rs 94.44% <100%> (ø)
tests/interpreter.rs 95% <100%> (ø)
src/vm/value.h 100% <100%> (ø)
src/hanayo/proc.rs 71.66% <100%> (ø)
tests/hanayo.rs 99.63% <100%> (ø)
src/vmbindings/gc.rs 83.7% <100%> (ø)
src/vmbindings/record.rs 95.65% <100%> (ø)
src/hanayo/int.rs 96.55% <100%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ac5d6b8...2c82943. Read the comment docs.

codecov-io avatar Jun 03 '19 15:06 codecov-io

I've decided not to merge this due to a significant performance regression (benchmarks are 10-15% slower, however it consumes 10% less memory)

If anyone can find a way to fix this regression, please comment here.

ffwff avatar Jun 04 '19 03:06 ffwff