FFmpeg icon indicating copy to clipboard operation
FFmpeg copied to clipboard

Add fate tests for palette act and field

Open QSXW opened this issue 7 months ago • 7 comments

The fix for DUAL_CHROMA_TREE coding unit was lost in our rebased commits. Please help review https://github.com/ffvvc/FFmpeg/pull/291/commits/0f9b47af108fd39a77970f5d871f781ea9da6541

QSXW avatar Jun 03 '25 18:06 QSXW

The fix for DUAL_CHROMA_TREE coding unit was lost in our rebased commits. Please help review 0f9b47a

thank you for the patch

For which specific clip are you seeing the issue? All ACT clips pass locally with the upstream code.

like: ACTPIC_A_Huawei_3.bit ACTPIC_B_Huawei_3.bit ACTPIC_C_Huawei_3.bit ACT_A_Kwai_3.bit ACT_B_Kwai_3.bit

nuomi2021 avatar Jun 07 '25 14:06 nuomi2021

The fix for DUAL_CHROMA_TREE coding unit was lost in our rebased commits. Please help review 0f9b47a

thank you for the patch

For which specific clip are you seeing the issue? All ACT clips pass locally with the upstream code.

like: ACTPIC_A_Huawei_3.bit ACTPIC_B_Huawei_3.bit ACTPIC_C_Huawei_3.bit ACT_A_Kwai_3.bit ACT_B_Kwai_3.bit

It's the one encoded by myself. See https://github.com/ffvvc/FFmpeg/pull/224#discussion_r2033909419

We should use the width and height of the start component. When the cu is DUAL_CHROMA_TREE, the start component is the first transform block, so we need to use the tb width and height.

QSXW avatar Jun 08 '25 14:06 QSXW

It's the one encoded by myself. See #224 (comment)

We should use the width and height of the start component. When the cu is DUAL_CHROMA_TREE, the start component is the first transform block, so we need to use the tb width and height.

could you share the DUAL_CHROMA_TREE clip with me? Thank you

nuomi2021 avatar Jun 09 '25 12:06 nuomi2021

It's better to remove the company name from the clip, just like the other FATE clips.

nuomi2021 avatar Jun 09 '25 12:06 nuomi2021

It's the one encoded by myself. See #224 (comment) We should use the width and height of the start component. When the cu is DUAL_CHROMA_TREE, the start component is the first transform block, so we need to use the tb width and height.

could you share the DUAL_CHROMA_TREE clip with me? Thank you

Sure. https://github.com/user-attachments/assets/91fce515-47bf-45e6-bc32-4473eba2260f

To upload the clip, I changed the file extension from bit to mp4. You need to change it back.

Open the link and use Ctrl + S to download the clip.

QSXW avatar Jun 09 '25 13:06 QSXW

@nuomi2021 Let's get this to mainline. Should I send it to the mailing list?

QSXW avatar Aug 04 '25 22:08 QSXW

+1. Better to group patches with related functions and send them to the mailing list separately.

nuomi2021 avatar Aug 08 '25 03:08 nuomi2021