Roman Titov

Results 77 comments of Roman Titov

> Thanks for putting this PR together 👍 > > Before going into the details I'd like to know what is the background for this feature? Did someone ask for...

@generall @agourlay @timvisee I've reorganized `tracing.rs` once again (that's the last time, I promise). 🙈 Barely changed anything, just reorganized and renamed structures/functions. The structure might seem weird, but it...

@generall @agourlay @timvisee I think this is good enough for a final review. __UPD:__ Should I update default config file with the new directives, or do we want to keep...

@timvisee I'm like 99% sure I've tested an empty request (cause I've been testing and tweaking serialization/deserialization), but I'll check this once again real quick.

Everything works on my machine. And, btw, I'm testing it under Docker, so I'm actually running Linux binary... :')

Let's leave it for now, I'll come back to it after I return from my vacation. :(

> * Do not combine refactoring and new features in one PR Noted. > * Do not include questionable functionality. `span_events` doesn't have immediate use, or at least it doesn't...

@generall did some further cleanup and added trivial diff update for the logger config

I'm using this branch for "missing payload" bug debug now. I think, once I'm done (just in case I'd like to introduce some additional changes), we can revisit and merge...