Results 65 comments of ffranr

I've included changes which were found necessary from the proof-of-concept investigation.

> I made some additional changes to the custom records here: [8a4531f#diff-dcf3ed2a4ce04d1e140efd7a8d84967d7b7d04e69be69fdeb3a95c0350ac3b58](https://github.com/lightningnetwork/lnd/commit/8a4531fc9680f85040fdebce93e1fef3541482c2#diff-dcf3ed2a4ce04d1e140efd7a8d84967d7b7d04e69be69fdeb3a95c0350ac3b58) Would be nice to get those in as well. Latest commits should include the custom record changes found...

Added RPC to solve this issue: https://github.com/lightninglabs/pool/pull/395

Thanks for the review @guggero and for answering my questions! I believe my latest update has addressed your comments, please let me know if I've missed anything.

Thank you for your latest review @guggero ! You're right I should always try out the code before I request a review. I'll make sure that I do. I've tried...

@guggero Thanks for the review. I've added `txid` as you suggested. I've tested by checking the RPC return after creating a pool account. You mentioned a "[byte reverse order problem](https://github.com/lightninglabs/pool/pull/395#discussion_r1022576738)",...

@guggero Thanks for the review! I've addressed your comments here: https://github.com/lightningnetwork/lnd/pull/8954 I couldn't reopen this PR, I think because I forced push before re-opening, not sure.

MD5 is a failed hash function that should never be used again (see: wikipedia): > One basic requirement of any cryptographic hash function is that it should be computationally infeasible...