Results 65 comments of ffranr

> I think I also need to pass circuit key for latest HTLC along with invoice to settlement interceptor client. This way the client can inspect the correct HTLC. This...

I'm in the process of writing an itest for this PR. I noticed that providing the exit HTLC circuit key to the acceptor interceptor client is insufficient. The invoice will...

Latest state: 1. New integration test which shows that an invoice can be forced into the settled state (using the new interceptor) when the exit HTLC amount is less than...

I need to double check whether there are modifications in the PoC branch which relate to this PR.

There are two things left to do here: 1. Add support for modifying (via HTLC interception) p2p message `lnwire.UpdateFulfillHTLC`. 2. Write received `UpdateAddHTLC` to log so that the itest can...

> There are two things left to do here: > > 1. Add support for modifying (via HTLC interception) p2p message `lnwire.UpdateFulfillHTLC`. > > 2. Write received `UpdateAddHTLC` to log...

New message encode/decode changes are in place. Still need to modify `lnwire.UpdateFulfillHTLC`, but a review at this point would be useful to ensure correct encode/decode.

Latest on this PR: 1. I've modified the custom records field encode/decode procedure. It's now serialized "flat" in the `ExtraData` field. Things to consider: Similar modifications are (probably) necessary for...

The latest on this PR: 1. I've added a custom record field to `UpdateFulfillHtlc`. The HTLC interceptor can now modify the custom records field on `update_fulfill_htlc` and `update_add_htlc` messages. 2....

I've just add encoding/decoding unit tests for `UpdateFulfillHtlc`. PR should be ready for merge, IMO.