a11y.css icon indicating copy to clipboard operation
a11y.css copied to clipboard

[question] inline svg with role="img" and aria-hidden

Open nico3333fr opened this issue 5 years ago • 1 comments

While testing ProtonMail v4, I found maybe one issue:

  • it says that a SVG> is missing aria-label or aria-labelledby

For this code:

<svg viewBox="0 0 16 16" class="icon-24p" role="img" aria-hidden="true" focusable="false"> <use xlink:href="#shape-twitter"></use> </svg> Our Twitter account (example here: https://design-system.protontech.ch/icons/#integration-cases)

Accede-web says we should use aria-hidden https://www.accede-web.com/notices/html-et-css/images-et-icones/gerer-lalternative-des-svg-images-vectorielles/#ancre-01

Who should I believe? :) Or maybe restrict the test to elements that are not aria-hidden ?

Cheers and thanks for advice ;)

Btw, some links are broken https://ffoodd.github.io/a11y.css/errors.html#no-aria-label

nico3333fr avatar Jul 06 '20 16:07 nico3333fr

I think we should exclude aria-hidden 👌

ffoodd avatar Jul 06 '20 16:07 ffoodd

Sidenote to PR: links don't seem broken anymore

PhilippeVay avatar Jul 29 '23 09:07 PhilippeVay