freesound-explorer icon indicating copy to clipboard operation
freesound-explorer copied to clipboard

Should settings really be a storable reducer?

Open giuband opened this issue 9 years ago • 1 comments

Right now this could happen and it feels weird:

  1. Change any of the settings (for instance, turning on playSoundsOnHover)
  2. Create new session
  3. See all of your settings magically going back to their initialState, as defined in the reducer

Is this what we really want? (semi-quote from Fargo)

giuband avatar Sep 27 '16 20:09 giuband

I think this depends on the setting. For now we only have 'play on hover' setting and for me this is an "artistic" decision, therefore it should be part of the session. I think this debate will make more sense once we have more configurable settings...

ffont avatar Sep 28 '16 08:09 ffont