hola icon indicating copy to clipboard operation
hola copied to clipboard
verified publisher icon fflewddur

TXT record parsing fails when data length is 0

Open darmbrust opened this issue 6 years ago • 2 comments

Exception in thread "Thread-2" java.nio.BufferUnderflowException at java.base/java.nio.HeapByteBuffer.get(HeapByteBuffer.java:178) at java.base/java.nio.ByteBuffer.get(ByteBuffer.java:762) at net.straylightlabs.hola.dns.Record.readLabel(Record.java:122) at net.straylightlabs.hola.dns.Record.readStringsFromBuffer(Record.java:137) at net.straylightlabs.hola.dns.TxtRecord.(TxtRecord.java:39) at net.straylightlabs.hola.dns.Record.fromBuffer(Record.java:74) at net.straylightlabs.hola.dns.Response.parseRecords(Response.java:77) at net.straylightlabs.hola.dns.Response.createFrom(Response.java:45) at net.straylightlabs.hola.sd.Query.collectResponses(Query.java:218)

darmbrust avatar Apr 21 '20 22:04 darmbrust

screenshot17

Wireshark capture of the response in question

darmbrust avatar Apr 21 '20 22:04 darmbrust

fixed in the above commit on my fork, if you need a release, see https://github.com/Sagebits/hola/releases/tag/v0.2.4-sagebits

also published to maven central as

<dependency>
	<groupId>net.sagebits</groupId>
	<artifactId>hola</artifactId>
	<version>0.2.4-sagebits</version>
</dependency>

darmbrust avatar Apr 22 '20 02:04 darmbrust