lua-resty-acme icon indicating copy to clipboard operation
lua-resty-acme copied to clipboard
verified publisher icon fffonion

Move to lua-resty-redis-connector to support sentinel

Open cdloh opened this issue 5 years ago • 3 comments

Would you be happy to move to lua-resty-redis-connector over base lua-resty-redis so that redis sentinel instances can be supported?

This will make it easier to load balance it and make redis HA.

cdloh avatar Nov 23 '20 12:11 cdloh

@cdloh I'd prefer to keep dependency as light as possible, as lua-resty-redis is a library shipped with openresty. But I don't think it's a bad idea to support redis sentinel. Is it possible that we support both: if user don't have lua-resty-redis-connector installed we can fallback to lua-resty-redis?

fffonion avatar Nov 23 '20 13:11 fffonion

@fffonion makes sense. Are you happy if it's loaded like lfs_ffi & lfs are in the file storage adapter?

cdloh avatar Nov 23 '20 14:11 cdloh

like lfs_ffi & lfs are in the file storage adapter

Yes exactly 👍

fffonion avatar Nov 23 '20 15:11 fffonion

Closing this for inactivity, if this becomes a demanding feature from community I will re-open it.

fffonion avatar Mar 27 '24 16:03 fffonion