juice icon indicating copy to clipboard operation
juice copied to clipboard

Move `juice-examples` out from `juice` repo

Open andreytkachenko opened this issue 5 years ago • 7 comments

Because cargo does not supports workspaces inside workspace, but I do want to add some more example networks (besides MNIST)

andreytkachenko avatar Jun 17 '19 10:06 andreytkachenko

Are you sure, removing was primarily motivated due to it's old hyper-tls and thus openssl requirement. I observed no other errors during build.

What cargo/rustc version are you using?

drahnr avatar Jun 17 '19 15:06 drahnr

rustc --version: 1.37.0-nightly (5d8f59f4b 2019-06-04)

It works fine, I've fixed issues in #46. My concerns is that, I would like to have several different examples (each one as a separate crate) under examples folder. May be it is good to have examples folder inside juice itself showing some basic examples (i.e. MNIST), but also separate repo - examples of models (AlexNet, Yolo, MobileNet, Wave-U-Net, etc.)

andreytkachenko avatar Jun 18 '19 08:06 andreytkachenko

I think that's the best approach for the time being. We could still discussing maybe example just holds a set of examples. I'd like to keep at least one in there to assure a working demo.

drahnr avatar Jun 18 '19 09:06 drahnr

Another approach would be to use the juice-examples as a nested workspace which contains all examples as individual projects. What do you think?

drahnr avatar Jan 02 '20 12:01 drahnr

Individual binaries is more common for this type of data science library - it's expected that users will copy a binary in full and modify it to suit their needs before writing something from scratch, and keeping each example independent would help towards that.

lissahyacinth avatar Jan 08 '20 15:01 lissahyacinth

Alright, so a nested workspace would work 👏 - possibly with overwrites to work with the juice present in the repo usable for integration tests too

drahnr avatar Jan 08 '20 16:01 drahnr

Conclusion was to automate export of juice examples on release via CI to separate repositories, which work with the crates.io upstream. Also note that currently cargo does not support nested workspaces.

drahnr avatar Jul 22 '20 08:07 drahnr