PointPillars icon indicating copy to clipboard operation
PointPillars copied to clipboard

Inconsistent units of bounding box yaws

Open RM-Costa opened this issue 4 years ago • 3 comments

In config.py, the yaws are written in radians, but in point_pillars_test.py they're in degrees.

Is this a bug or am I missing something ?

RM-Costa avatar Aug 11 '20 09:08 RM-Costa

This is the updated version of this repo: https://github.com/tyagi-iiitv/PointPillars.

tyagi-iiitv avatar Aug 14 '20 04:08 tyagi-iiitv

This is the updated version of this repo: https://github.com/tyagi-iiitv/PointPillars.

Thanks for the answer, but I still see the same issue in your fork. In config.py the anchor boxes orientation is in radians, but in point_pillars_test.py the yaws are in degrees. These values are used in the IoU computation, which uses std::cos and std::sin operations, so the units should be all in radians for the code to work properly.

RM-Costa avatar Aug 14 '20 09:08 RM-Costa

I've added this as an issue on my repo, I'll verify and work on it. In the meantime, if you want to submit a PR to my repo, go ahead with that. Anyway, I'll let you know when this is fixed.

tyagi-iiitv avatar Aug 17 '20 04:08 tyagi-iiitv