pole-zero: pull request branch for supporting pole-zero plots

[josmithiii]

This pull request adds open circles (o) and crosses (x) to XYDragComponent. See screenshot for an example of how it can look.

[ffAudio]

Hi Julius, Sorry for letting this lying around. I think it would be a great addition. IIRC it was the same issue about the not being unavailable on windows, is that possible? If you update that so it succeeds on windows too, I am happy to merge it. Cheers!

[josmithiii]

Hi Daniel,

Thanks for circling back - no hurries. Unfortunately the logs are expired. It appears I need to force the checks to run again. I'll see if I can figure out what to do . . .

[josmithiii]

I tried re-synching my fork and refreshing the PR - awaiting actions I presume

[ffAudio]

Ok, it is building now. Although I was thinking about it:

• first idea was to create a LookAndFeel method for the XY-dragger This way you could create a bespoke draw function yourself. The drawback would be, it could be crowded with LookAndFeels.

• second idea: create a LookAndFeel but allow a fixed number like 8 different shapes you can select like you did... Are those poles just for displaying or are they interactive?

[ffAudio]

Hi Julius,

The logs are pretty cluttered, there is another "not": https://github.com/ffAudio/foleys_gui_magic/actions/runs/7965743902/job/21745986167#step:5:463

D:\a\foleys_gui_magic\foleys_gui_magic\modules\foleys_gui_magic\General/foleys_MagicJUCEFactories.cpp(671,13)

In the braces there is the line number 671

I like the PR, but other users might want the drawing to be more fancy, so I will think of a way to make it customizable...

Thank you for your input, it is great to see it is being used.

Currently I started working on it again, I want to add some DSP builder as well, so people can create a full plugin similar to Reaktor or RNBO. That would mean adding some DSP building blocks as well, which can then be connected to the visualisers in the GUI. A way to define the parameters in the XML already exists now.

I'll keep you updated if you are interested.

All the best Daniel

On Mon, 19 Feb 2024 at 23:26, Julius Smith @.***> wrote:

I tried re-synching my fork and refreshing the PR - awaiting actions I presume

— Reply to this email directly, view it on GitHub https://github.com/ffAudio/foleys_gui_magic/pull/94#issuecomment-1953228929, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEFFHO7JPUVGJ6YU7NGDY2DYUPGSFAVCNFSM6AAAAAA3CQEXNSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJTGIZDQOJSHE . You are receiving this because you commented.Message ID: @.***>

-- Mit freundlichen Grüßen - Kind regards Daniel Walz

Foleys Finest Audio UG (haftungsbeschränkt) Daniel Walz Hinterer Holzweg 37 73733 Esslingen am Neckar Germany

@.*** https://foleysfinest.com http://www.foleysfinest.com https://www.linkedin.com/in/daniel-walz/ http://www.foleysfinest.com

[josmithiii]

Super happy to hear you are working on PGM again! I checked out my PR, changed 'not' to '!', and it builds and tests ok for me. How do I trigger a Windows recompile attempt, or is that automatic?