raintpl3 icon indicating copy to clipboard operation
raintpl3 copied to clipboard

Published 20 hours ago • verified publisher icon feulf

Undefined index: remove_comments in Rain/Tpl/Parser.php on line 304

Open xPaw opened this issue 11 years ago • 2 comments

Either this variable should be added to config, or let the compress plugin do that job.

xPaw avatar Aug 04 '13 15:08 xPaw

The Compress plugin is not completed, because for compressing HTML there is RainCache, which has a plugin to compress HTML, CSS and Javascript: https://github.com/rainphp/RainCache

So the simplest solution is to insert the $conf['remove_comments'], we can decide later if we want to move this out of the class and into a plugin.

feulf avatar Aug 04 '13 23:08 feulf

here's the pull request: https://github.com/rainphp/raintpl3/pull/100 can you please review?

feulf avatar Aug 04 '13 23:08 feulf